Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue comments: implement pagination & show all comments #264

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

claytonrcarter
Copy link
Collaborator

This closes #258

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #264 into master will increase coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   69.56%   69.63%   +0.06%     
==========================================
  Files          44       44              
  Lines        2481     2490       +9     
==========================================
+ Hits         1726     1734       +8     
- Misses        583      584       +1     
  Partials      172      172
Impacted Files Coverage Δ
internal/gitlab/gitlab.go 43.82% <75%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751950f...64c4352. Read the comment docs.

@zaquestion zaquestion merged commit be24c68 into zaquestion:master Dec 17, 2018
@claytonrcarter claytonrcarter deleted the fix-issue-comments branch January 18, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue show (comments): Implement pagination
2 participants