get the CurrentBranch from git instead of parsing text #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaquestion
reviewed
Feb 21, 2019
| func CurrentBranch() (string, error) { | ||
| cmd := New("branch") | ||
| cmd.Stdout = nil |
There was a problem hiding this comment.
Error in CI is because you still need this line I'm afraid. Great looking changes tho! Love deleted code!
zaquestion
added a commit
that referenced
this pull request
Jul 25, 2019
|
Closing in favor of #324 to bring in these changes |
|
Hey, thanks for fixing this, and sorry for forgetting about this PR 🤦♂️ |
|
You're welcome, no worries, I would have poked you again, but was just on a roll at GopherCon joyfully catching up on the open PRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.