mr_create: fix the target remote #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prarit Sure, no problem, I'll rebase and update this PR. |
The remote used as a target can be given in the command line with: lab mr create remote/repository/name It was however not taken into account when comparing the branch to merge and the target branch, and when making the cover letter template. Instead the initial forked from branch was used, which would be invalid if the repository wasn't forked at first from the target one. Fix this. Signed-off-by: Antoine Tenart <atenart@kernel.org>
atenart
force-pushed
the
mr-create-target-remote
branch
from
6676bdb to
7c7f840
Compare
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
- Coverage 58.30% 58.20% -0.10%
==========================================
Files 64 64
Lines 4197 4197
==========================================
- Hits 2447 2443 -4
- Misses 1516 1519 +3
- Partials 234 235 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes an issue where the target remote name can be wrong, if the repository wasn't forked from the target at first.
Thanks!