fix project lookup during fork #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a fork process, lab doesn't check if a fork with same name under user's namespace is a fork from the same project the user is trying to fork now. If the same name matches, it only return a reference for that project, regardless where it came from. This patch adds a check step to make sure the found project is indeed a fork for the same project being forked. Otherwise, it returns an error informing the user. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
bmeneg
force-pushed
the
fix-fork-findproject
branch
from
0b45299 to
aafaffb
Compare
|
Oops.. the commit " Completely drop hub support " was meant to another PR in the near future. |
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 57.57% 57.39% -0.19%
==========================================
Files 67 68 +1
Lines 4347 4354 +7
==========================================
- Hits 2503 2499 -4
- Misses 1602 1612 +10
- Partials 242 243 +1
Continue to review full report at Codecov.
|
zaquestion
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the project the user wants to fork matches the project that another fork, with the same name, was based on.