Git command warning #630
Merged
Git command warning #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsteube
reviewed
Mar 10, 2021
cmd/root.go
Outdated
| @@ -228,6 +222,7 @@ func Execute() { | |||
| } | |||
| } | |||
| if !knownFlag { | |||
| fmt.Println("Warning: lab's git passthrough command support will be removed in a later release.") | |||
There was a problem hiding this comment.
@prarit shouldn't these be written to stderr?
There was a problem hiding this comment.
Oh of course. Thanks for catching that.
|
I just merged #629, could you rebase this PR to consider the merge code? :) |
lab is a command line utility for GitLab. It does wrap around git currently, however, that isn't lab's primary purpose. Update lab's description. Additional fix: Remove some dead code. Additional fix: Warn git wrapper users that git wrap functionality will eventually be removed. Signed-off-by: Prarit Bhargava <prarit@redhat.com>
prarit
force-pushed
the
git_command_warning
branch
from
b48f078 to
6ff246b
Compare
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 56.14% 56.21% +0.07%
==========================================
Files 73 73
Lines 4613 4609 -4
==========================================
+ Hits 2590 2591 +1
+ Misses 1772 1767 -5
Partials 251 251
Continue to review full report at Codecov.
|
JohnVillalovos
added a commit
to JohnVillalovos/lab
that referenced
this pull request
Dec 9, 2021
Based on zaquestion#630, it appears that the project no longer wants people to use lab as a replacement for the git command. So we shouldn't recommend to people that the do `alias git=lab`. Update README.md to remove this recommendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few users have been asking about lab's purpose relative to git. The current description of the tool "A Git Wrapper for GitLab" is not accurate and should be updated to reflect that lab is a command line utility for GitLab.
Also, output a warning for git wrapper users -- we know this code is going away in the future and we should be encouraging people to not write scripts that depend on lab's git wrapper.
Signed-off-by: Prarit Bhargava prarit@redhat.com