Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tests,fix) coverage for clone test was getting trapped inside the repo dir #64

Merged
merged 1 commit into from
Dec 16, 2017

Conversation

zaquestion
Copy link
Owner

  • when adding the upstream remote well run the command from the directory instead of changing to the directory to run the command for now on. This is probably how I should have done it the first time, that logic is written by someone who doesnt use the "upstream" paradigm

…po dir

- when adding the upstream remote well run the command from the directory instead of changing to the directory to run the command for now on. This is probably how I should have done it the first time, that logic is written by someone who doesnt use the "upstream" paradigm
@codecov
Copy link

codecov bot commented Dec 16, 2017

Codecov Report

Merging #64 into master will increase coverage by 1.55%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   53.72%   55.27%   +1.55%     
==========================================
  Files          21       21              
  Lines         953      957       +4     
==========================================
+ Hits          512      529      +17     
+ Misses        308      287      -21     
- Partials      133      141       +8
Impacted Files Coverage Δ
main.go 100% <100%> (ø) ⬆️
cmd/fork.go 26.47% <100%> (ø) ⬆️
internal/git/git.go 69.36% <71.42%> (+0.56%) ⬆️
cmd/clone.go 40% <75%> (+33.1%) ⬆️
cmd/root.go 68.57% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6540c63...7e34590. Read the comment docs.

@zaquestion zaquestion merged commit 4cb0cfc into master Dec 16, 2017
@zaquestion zaquestion deleted the tests-cmd-3 branch December 17, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant