cmd: Add Issue show command #66
Conversation
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 55.83% 56.64% +0.81%
==========================================
Files 21 22 +1
Lines 969 1038 +69
==========================================
+ Hits 541 588 +47
- Misses 287 299 +12
- Partials 141 151 +10
Continue to review full report at Codecov.
|
cmd/issueShow.go
Outdated
|
|
||
| var issueShowCmd = &cobra.Command{ | ||
| Use: "show [remote]", | ||
| ArgAliases: []string{"s", "d"}, |
There was a problem hiding this comment.
Can you add a regular alias for get
Aliases: []string{"get"}
Also, consider dropping "d" as a short alias "d" makes me think "delete" over "describe".
| assignee = issue.Assignee.Username | ||
| } | ||
|
|
||
| fmt.Printf(` |
There was a problem hiding this comment.
This should be a template, but I'm tempted to say we can follow up on it.
Sample: https://github.com/zaquestion/lab/blob/master/cmd/issueCreate.go#L71
cmd/issueShow.go
Outdated
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| remote, _, err := parseArgsRemote(args) |
There was a problem hiding this comment.
The beginning of this function can just be
remote, issueNumber, err := parseArgsRemote(args)
cmd/issue.go
Outdated
| }, | ||
| } | ||
|
|
||
| func init() { | ||
| issueCmd.Flags().BoolP("list", "l", false, "list issues") | ||
| issueCmd.Flags().BoolP("create", "c", false, "create new issue") |
There was a problem hiding this comment.
Can we drop the create flag out of this pr? I wanna think about it more.
nkprince007
force-pushed
the
issue-show
branch
from
7042854 to
b1bd06d
Compare
nkprince007
force-pushed
the
issue-show
branch
from
b1bd06d to
a057d77
Compare
No description provided.