Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Add MR show command #69

Merged
merged 2 commits into from
Dec 17, 2017
Merged

Conversation

nkprince007
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 17, 2017

Codecov Report

Merging #69 into master will increase coverage by 0.71%.
The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   56.64%   57.36%   +0.71%     
==========================================
  Files          22       23       +1     
  Lines        1038     1100      +62     
==========================================
+ Hits          588      631      +43     
- Misses        299      308       +9     
- Partials      151      161      +10
Impacted Files Coverage Δ
cmd/mr.go 45.45% <25%> (+5.45%) ⬆️
internal/gitlab/gitlab.go 32.57% <50%> (+0.65%) ⬆️
cmd/mrShow.go 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca971f...be371ed. Read the comment docs.

Copy link
Owner

@zaquestion zaquestion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 1 requested change and I'm gonna merge this in as is since need to make the same change for issue too.

Short: "Work with merge requests",
Long: ``,
Short: mrShowCmd.Short,
Long: mrShowCmd.Long,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the Long and Short descriptions should stay how they are since the mr cmd has other functions under it. I realize I let this slip on the issue command, am intending to fix that before release. Potentially we could not in the long description that lab mr 1 will do a show

@zaquestion zaquestion merged commit cb699c9 into zaquestion:master Dec 17, 2017
@zaquestion zaquestion modified the milestone: 0.8.0 Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants