Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (ci status) #240 bump up default wait interval #704

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

zaquestion
Copy link
Owner

Per discussion in #240, lets just bump up the interval, totally open to putting it behind a flag, but in the context of waiting for a an entire pipeline to finish, 1s is clearly a bit too aggressive.

Per discussion in #240, lets just bump up the interval, totally open to putting it behind a flag, but in the context of waiting for a an entire pipeline to finish, 1s is clearly a bit too aggressive.
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #704 (e744d4a) into master (ad3de9c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   55.42%   55.42%           
=======================================
  Files          77       77           
  Lines        4920     4920           
=======================================
  Hits         2727     2727           
  Misses       1935     1935           
  Partials      258      258           
Impacted Files Coverage Δ
cmd/ci_status.go 84.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3de9c...e744d4a. Read the comment docs.

Copy link
Collaborator

@bmeneg bmeneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1s -> 10s is fine considering the time an usual CI takes.
And I agree, adding a flag might be better, but lets make it 10s first :)

@zaquestion
Copy link
Owner Author

Yeah, exactly

@zaquestion zaquestion merged commit f6b2f82 into master Jun 30, 2021
@zaquestion zaquestion deleted the ci_status_wait_interval branch June 30, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants