Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mr_create: clarify help wrt source and target remotes and branches #731

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

bmeneg
Copy link
Collaborator

@bmeneg bmeneg commented Aug 12, 2021

The current help message is a bit confusing about what's target and what's
source remote and branches. The user should not need to guess what we mean.
With that, explicitly state target_remote and target_branch for positional
args and make the examples clearer.

Signed-off-by: Bruno Meneguele bmeneg@redhat.com

The current help message is a bit confusing about what's target and what's
source remote and branches. The user should not need to guess what we mean.
With that, explicitly state target_remote and target_branch for positional
args and make the examples clearer.

Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
@bmeneg bmeneg requested a review from zampierilucas August 12, 2021 11:20
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #731 (1ac0f1b) into master (867b3ce) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   55.96%   55.96%           
=======================================
  Files          77       77           
  Lines        5384     5384           
=======================================
  Hits         3013     3013           
  Misses       2097     2097           
  Partials      274      274           
Impacted Files Coverage Δ
cmd/mr_create.go 79.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867b3ce...1ac0f1b. Read the comment docs.

@bmeneg bmeneg merged commit 6790622 into zaquestion:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants