Bump dependencies, delete integration tests #227
Conversation
.github/workflows/ci.yml
Outdated
| - uses: GabrielBB/xvfb-action@v1.6 | ||
| with: | ||
| run: pnpm integration-test |
There was a problem hiding this comment.
I reverted the commit where you deleted the integration tests from the pipeline (see 774358a)
I think we should either delete integration tests entirely or add them to the pipeline.
There was a problem hiding this comment.
id better delete them entirely i dont think its worth and even possible to restore them
|
Agree, doesn't really matter what way we go here |
.github/workflows/ci.yml
Outdated
| - uses: GabrielBB/xvfb-action@v1.6 | ||
| with: | ||
| run: pnpm integration-test |
There was a problem hiding this comment.
id better delete them entirely i dont think its worth and even possible to restore them
Integration tests are hard to fix and maintain in their current state Refs: * Discussion - #227 (comment)
Integration tests are hard to fix and maintain in their current state Refs: * Discussion - #227 (comment)
Integration tests are hard to fix and maintain in their current state Refs: * Discussion - #227 (comment)
Ilanaya
changed the title
| "typed-jsonfile": "^0.2.1", | ||
| "typescript": "5.3.3", | ||
| "vite": "^4.1.1", | ||
| "typescript": "5.5.0-dev.20240523", |
There was a problem hiding this comment.
@zardoy This is the latest version (npm link), which doesn't have the cannot find namespace 'ts' error.
I found that you already had a conversation with a typescript team member referencing this problem, yet it didn't help me to find the solution to preserve the global ts type.
RN I can see the 2 approaches:
- Stick with the dev version in PR or downgrade to the latest release that supports global ts type declaration
- Explicitly add typescript type imports in every file and make sure that typescript is not bundled.
I think we need to go with the second one - these changes shouldn't be hard in the LLM era. WDYT?
Refs:
There was a problem hiding this comment.
Ok, now we have a lot of errors during pnpm vscode-utils prepareFrameworkBuild, that come from schema generation...
Will need time to figure out why this broke and how to fix this.
Integration tests are hard to fix and maintain in their current state Refs: * Discussion - #227 (comment)
Integration tests are hard to fix and maintain in their current state Refs: * Discussion - #227 (comment)
Uh oh!
There was an error while loading. Please reload this page.