feat: Insert double quotes on colon #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zardoy
changed the title
|
Seems to be fine, I'll be pushing code changes & integration tests |
1. matches with new test 2. no setting regression
…ed from JS, and not typing
|
@AgentRBY I did a lot of changes here, you can see them by commits. I understand that probably this this logic for insert position might not be easy to understand, but its short & works well (you can see this in test). Are these changes good for you, can I merge? Unfortunately I needed to disable new integration tests on CI (of course you can replace |
|
LGTM, you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10
