retry removals of directories that have been recently archived b/c of…

… windows bug

fix related to the following issue: golang/go#51442

src/internal/packager/sbom/catalog.go

@@ -141,7 +141,10 @@ func Catalog(componentSBOMs map[string]*types.ComponentSBOM, imgList []string, t
 		return err
 	}
 
-	_ = os.RemoveAll(builder.tmpSBOMPath)
+	if err := utils.RetryRemoveAll(builder.tmpSBOMPath, 3); err != nil {
+		return fmt.Errorf("unable to remove the temporary SBOM directory: %w", err)
+	}
+
 	builder.spinner.Success()
 
 	return nil

src/pkg/packager/create.go

@@ -191,8 +191,8 @@ func (p *Packager) Create(baseDir string) error {
 		}
 
 		// Remove the deflated component directory
-		if err := os.RemoveAll(componentPaths.Base); err != nil {
-			message.Debugf("unable to remove the component directory (%s): %s", componentPaths.Base, err.Error())
+		if err := utils.RetryRemoveAll(componentPaths.Base, 3); err != nil {
+			return fmt.Errorf("unable to remove the component directory (%s): %w", componentPaths.Base, err)
 		}
 	}
 

src/pkg/utils/io.go

@@ -17,6 +17,7 @@ import (
 	"path/filepath"
 	"regexp"
 	"strings"
+	"time"
 
 	"github.com/defenseunicorns/zarf/src/pkg/message"
 	"github.com/otiai10/copy"
@@ -253,3 +254,18 @@ func GetDirSize(path string) (int64, error) {
 
 	return dirSize, err
 }
+
+// RetryRemoveAll will attempt to remove an item or directory up to the given number of retries.
+// NOTE: This function is necessary because of a Windows bug with removing files that have been recently used: https://github.com/golang/go/issues/51442
+func RetryRemoveAll(path string, retries int) error {
+	for i := 0; i < retries; i++ {
+		err := os.RemoveAll(path)
+		if err == nil {
+			return nil
+		}
+
+		time.Sleep(500 * time.Millisecond)
+	}
+
+	return os.RemoveAll(path)
+}