Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): packager warnings to be a proper type or struct #2338

Open
lucasrod16 opened this issue Feb 27, 2024 · 1 comment
Open

chore(refactor): packager warnings to be a proper type or struct #2338

lucasrod16 opened this issue Feb 27, 2024 · 1 comment
Labels
good first issue 🥇 Good for newcomers

Comments

@lucasrod16
Copy link
Contributor

Describe what should be investigated or refactored

refactor packager warnings to be a proper type or struct

Links to any relevant code

https://github.com/defenseunicorns/zarf/blob/22f2598e33dc28e91ed8609bbfb6b134113b2f9f/src/pkg/packager/common.go#L41

Additional context

#2223 (comment)

cc: @Noxsios

@AustinAbro321
Copy link
Contributor

I think we'll probably want to combine at least some of the warnings with the lint / validator. I believe we already have some duplicated logic in the lint code anyway

@lucasrod16 lucasrod16 self-assigned this Mar 19, 2024
@lucasrod16 lucasrod16 changed the title refactor packager warnings to be a proper type or struct chore(refactor): packager warnings to be a proper type or struct Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🥇 Good for newcomers
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants