Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: packager Warnings type #2388

Closed
wants to merge 13 commits into from

Conversation

lucasrod16
Copy link
Contributor

@lucasrod16 lucasrod16 commented Mar 19, 2024

Description

refactor package warnings to be a struct rather than a string slice

Related Issue

Fixes #2338

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 07cc4f4
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/661565e9fb34a000071825bc

@lucasrod16 lucasrod16 self-assigned this Mar 19, 2024
@lucasrod16 lucasrod16 marked this pull request as ready for review March 20, 2024 15:57
@Noxsios Noxsios changed the title chore(refactor): packager warnings to be a struct refactor: packager warnings to be a struct Mar 20, 2024
@Noxsios Noxsios changed the title refactor: packager warnings to be a struct refactor: packager Warnings type Mar 20, 2024
@lucasrod16
Copy link
Contributor Author

Warnings are being cleaned up in: #2211

Closing this PR

@lucasrod16 lucasrod16 closed this Apr 9, 2024
@lucasrod16 lucasrod16 deleted the 2338-refactor-packager-warnings branch April 9, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(refactor): packager warnings to be a proper type or struct
2 participants