Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zarf Test Week MegaIssue #2512

Closed
4 of 17 tasks
schristoff-du opened this issue May 16, 2024 · 0 comments · Fixed by #2540
Closed
4 of 17 tasks

Zarf Test Week MegaIssue #2512

schristoff-du opened this issue May 16, 2024 · 0 comments · Fixed by #2540
Assignees
@phillebaba @AustinAbro321 @Noxsios @lucasrod16

Comments

@schristoff-du
Copy link
Contributor

schristoff-du commented May 16, 2024 •
edited by Noxsios
Loading

Goal: This issue will lead test week work

Single Issues:

Unit Tests (focus areas):

  • src/cmd
  • src/internal/agent
  • pkg/packager
    • pkg/packager/sources
    • pkg/packager/filters
    • pkg/packager/composer
    • pkg/packager/creator
  • src/pkg/cluster

E2E:

  • Identify if E2E is running sequentially (if yes, resolve. If no, remove numbering system)
  • Remove retries and waits where possible (this is to reduce the amount of time e2e takes to run)
@lucasrod16 lucasrod16 mentioned this issue May 18, 2024
Closed
2 tasks
This was referenced May 20, 2024
Merged
Merged
@AustinAbro321 AustinAbro321 mentioned this issue May 20, 2024
Merged
2 tasks
AustinAbro321 added a commit that referenced this issue May 20, 2024
@AustinAbro321
test: cluster getDeployedPackages (#2523)
514e82e 
## Description

Adds test for GetDeployedPackage and GetDeployedZarfPackages

## Related Issue

Relates to #2512 

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed
AustinAbro321 added a commit that referenced this issue May 20, 2024
@phillebaba @AustinAbro321
test: add unit tests for merge zarf state (#2522)
29d3ee3 
## Description

Add tests for merge zarf state.

## Related Issue

Relates to #2512 

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
@phillebaba phillebaba mentioned this issue May 21, 2024
Merged
2 tasks
This was referenced May 21, 2024
Merged
Merged
AustinAbro321 added a commit that referenced this issue May 21, 2024
@AustinAbro321
test: pod agent unit tests (#2526)
097a6ee 
## Description

This also changes how we the agent gets secrets from the cluster.
Instead of mounting secrets in the deployment and reading from a file
the agent will instead read the secret directly from the cluster. This
is done for simplicity, and easier testing. Additionally, the agent will
need to read from the cluster in #1974 as well so this helps prepare for
that change.

This only changes and tests pods to keep the scope of the PR slim. This
means temporarily the agent will both read from mounted file secrets and
regular kubernetes secrets depending on the hook, but this will be
changed shortly in future PRs.

## Related Issue

Relates to #2512 

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
This was referenced May 22, 2024
Merged
Merged
AustinAbro321 pushed a commit that referenced this issue May 22, 2024
@phillebaba @Noxsios
test: add unit tests for detect distro (#2521)
04e1c78 
## Description

Adds tests to detect distro logic.

## Related Issue

Relates to #2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
@phillebaba phillebaba mentioned this issue May 22, 2024
Merged
2 tasks
@lucasrod16 lucasrod16 mentioned this issue May 22, 2024
Merged
@phillebaba phillebaba mentioned this issue May 22, 2024
Closed
2 tasks
schristoff pushed a commit to schristoff/zarf that referenced this issue May 22, 2024
@AustinAbro321 @schristoff
test: pod agent unit tests (zarf-dev#2526)
fd43ac8 
## Description

This also changes how we the agent gets secrets from the cluster.
Instead of mounting secrets in the deployment and reading from a file
the agent will instead read the secret directly from the cluster. This
is done for simplicity, and easier testing. Additionally, the agent will
need to read from the cluster in zarf-dev#1974 as well so this helps prepare for
that change.

This only changes and tests pods to keep the scope of the PR slim. This
means temporarily the agent will both read from mounted file secrets and
regular kubernetes secrets depending on the hook, but this will be
changed shortly in future PRs.

## Related Issue

Relates to zarf-dev#2512 

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
schristoff pushed a commit to schristoff/zarf that referenced this issue May 22, 2024
@phillebaba @Noxsios @schristoff
test: add unit tests for detect distro (zarf-dev#2521)
9595d80 
## Description

Adds tests to detect distro logic.

## Related Issue

Relates to zarf-dev#2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
AustinAbro321 pushed a commit that referenced this issue May 22, 2024
@phillebaba
test: add tests for injector (#2534)
3c77d11 
## Description

Adds tests to injector.

## Related Issue

Relates to #2512 

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed
@AustinAbro321 AustinAbro321 mentioned this issue May 22, 2024
Merged
2 tasks
@lucasrod16 lucasrod16 mentioned this issue May 22, 2024
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
lucasrod16 pushed a commit that referenced this issue May 23, 2024
test: creator.ComposeComponents (#2537)
31d56e4 
Relates to #2512
Noxsios added a commit that referenced this issue May 23, 2024
@phillebaba @Noxsios
refactor: remove use of k8s serivce account (#2544)
f445e6d 
## Description

This change removes the k8s service account code and replaces it with
direct use of the client set instead.

## Related Issue

Relates to #2512 

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
Noxsios added a commit that referenced this issue May 23, 2024
@phillebaba @Noxsios
refactor: remove use of k8s service (#2543)
9d44452 
## Description

This change removes the k8s service code and replaces it with direct use
of the client set instead.

## Related Issue

Relates to #2512 

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
schristoff-du added a commit that referenced this issue May 23, 2024
@phillebaba @schristoff-du @Noxsios
refactor: remove use of k8s hpa (#2542)
249e91a 
## Description

This change removes the k8s hpa code and replaces it with direct use of
the client set instead.

## Related Issue

Relates to #2512 

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: schristoff <167717759+schristoff-du@users.noreply.github.com>
Co-authored-by: razzle <razzle@defenseunicorns.com>
Noxsios added a commit that referenced this issue May 23, 2024
@phillebaba @Noxsios @schristoff-du
test: add secrets tests (#2540)
2a8bfe2 
## Description

Adds tests to clusters secrets.

## Related Issue

Fixes #2512 

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
Co-authored-by: schristoff <167717759+schristoff-du@users.noreply.github.com>
lucasrod16 pushed a commit that referenced this issue May 23, 2024
@phillebaba
test: add test for packager source (#2525)
a69c44f 
## Description

This change adds tests for packager source which tests all
implementations.

## Related Issue

Relates to #2512 

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
lucasrod16 pushed a commit that referenced this issue May 23, 2024
@phillebaba @schristoff-du @Noxsios
test: clean up tests for composer (#2532)
c8c52d9 
## Description

Cleans up the composer tests to the newer testing style. Also marks test
helper functions as helpers.

## Related Issue

Relates to #2512 

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: schristoff <167717759+schristoff-du@users.noreply.github.com>
Co-authored-by: razzle <razzle@defenseunicorns.com>
Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
lucasrod16 pushed a commit that referenced this issue May 23, 2024
@AustinAbro321 @Noxsios @schristoff-du
test: argo agent unit tests (#2536)
1dcc140 
## Description

Relates to #2512 

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
Co-authored-by: razzle <razzle@defenseunicorns.com>
Co-authored-by: schristoff <167717759+schristoff-du@users.noreply.github.com>
@salaxander salaxander removed this from Zarf (old) Jun 25, 2024
AustinAbro321 added a commit that referenced this issue Jul 23, 2024
@AustinAbro321
test: cluster getDeployedPackages (#2523)
43f0f3f 
## Description

Adds test for GetDeployedPackage and GetDeployedZarfPackages

## Related Issue

Relates to #2512

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 added a commit that referenced this issue Jul 23, 2024
@phillebaba @AustinAbro321
test: add unit tests for merge zarf state (#2522)
e3220c2 
## Description

Add tests for merge zarf state.

## Related Issue

Relates to #2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 added a commit that referenced this issue Jul 23, 2024
@AustinAbro321
test: pod agent unit tests (#2526)
dbb1253 
## Description

This also changes how we the agent gets secrets from the cluster.
Instead of mounting secrets in the deployment and reading from a file
the agent will instead read the secret directly from the cluster. This
is done for simplicity, and easier testing. Additionally, the agent will
need to read from the cluster in #1974 as well so this helps prepare for
that change.

This only changes and tests pods to keep the scope of the PR slim. This
means temporarily the agent will both read from mounted file secrets and
regular kubernetes secrets depending on the hook, but this will be
changed shortly in future PRs.

## Related Issue

Relates to #2512

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @Noxsios @AustinAbro321
test: add unit tests for detect distro (#2521)
b9cf227 
## Description

Adds tests to detect distro logic.

## Related Issue

Relates to #2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @AustinAbro321
test: add tests for injector (#2534)
79a0016 
## Description

Adds tests to injector.

## Related Issue

Relates to #2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@AustinAbro321
chore: add unit tests for creator.LoadPackageDefinition (#2531)
b8cdf65 
Relates to #2512

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @Noxsios @AustinAbro321
test: refactor network test (#2533)
60ec5a0 
## Description

This change refactors the network tests to run in parallel and not
depend on files served by GitHub.

## Related Issue

Relates to #2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 added a commit that referenced this issue Jul 23, 2024
@AustinAbro321 @Noxsios
test: agent flux unit test (#2528)
b8f1189 
## Description

Relates to #2512

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
Co-authored-by: razzle <razzle@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@AustinAbro321
test: creator.ComposeComponents (#2537)
b33708a 
Relates to #2512

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @Noxsios @AustinAbro321
refactor: remove use of k8s serivce account (#2544)
1c58bb8 
## Description

This change removes the k8s service account code and replaces it with
direct use of the client set instead.

## Related Issue

Relates to #2512

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @Noxsios @AustinAbro321
refactor: remove use of k8s service (#2543)
424f029 
## Description

This change removes the k8s service code and replaces it with direct use
of the client set instead.

## Related Issue

Relates to #2512

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @schristoff-du
@Noxsios @AustinAbro321
refactor: remove use of k8s hpa (#2542)
d172126 
## Description

This change removes the k8s hpa code and replaces it with direct use of
the client set instead.

## Related Issue

Relates to #2512

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: schristoff <167717759+schristoff-du@users.noreply.github.com>
Co-authored-by: razzle <razzle@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @Noxsios
@schristoff-du @AustinAbro321
test: add secrets tests (#2540)
ce8678a 
## Description

Adds tests to clusters secrets.

## Related Issue

Fixes #2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
Co-authored-by: schristoff <167717759+schristoff-du@users.noreply.github.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @AustinAbro321
test: add test for packager source (#2525)
68476cc 
## Description

This change adds tests for packager source which tests all
implementations.

## Related Issue

Relates to #2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @schristoff-du
@Noxsios @AustinAbro321
test: clean up tests for composer (#2532)
9d6d9f0 
## Description

Cleans up the composer tests to the newer testing style. Also marks test
helper functions as helpers.

## Related Issue

Relates to #2512

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: schristoff <167717759+schristoff-du@users.noreply.github.com>
Co-authored-by: razzle <razzle@defenseunicorns.com>
Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 added a commit that referenced this issue Jul 23, 2024
@AustinAbro321 @Noxsios @schristoff-du
test: argo agent unit tests (#2536)
4f11338 
## Description

Relates to #2512

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
Co-authored-by: razzle <razzle@defenseunicorns.com>
Co-authored-by: schristoff <167717759+schristoff-du@users.noreply.github.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillebaba phillebaba

@AustinAbro321 AustinAbro321

@Noxsios Noxsios

@lucasrod16 lucasrod16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add secrets tests zarf-dev/zarf
5 participants
@phillebaba @AustinAbro321 @Noxsios @lucasrod16 @schristoff-du