-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor and purify the OCI library within Zarf. #2235
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to these changes we should also move /src/utils/helpers as well since that would be easy and is the core of a lot of our lib code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing more with @Noxsios it would likely be better to purify this functionality within Zarf (i.e. do the refactoring in Zarf for the OCI library to not rely on Zarf first, then move it out to keep things cleaner)
f845fcf
to
2c64297
Compare
2c64297
to
4dfa44c
Compare
pkg
repositoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Move OCI lib out, so it can be more easily used with other projects and contributed to by multiple teams.
Fixes: #2252 #2288
Type of change
Checklist before merging