-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move finding table printing to CLI #2960
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
I have removed the severity filter because I do not think it is being used. When calling Additionally we should start returning an exit code 1 for linter warnings. It should be up to the user to explicitly ignore this if they do not want to. |
7568cd7
to
73cf9de
Compare
Codecov ReportAttention: Patch coverage is
|
cb29862
to
3313708
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
3313708
to
37ebe1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, otherwise looks great
This PR contains the following updates: | Package | Update | Change | |---|---|---| | ghcr.io/zarf-dev/packages/init | minor | `v0.38.3` -> `v0.39.0` | | [zarf-dev/zarf](https://redirect.github.com/zarf-dev/zarf) | minor | `v0.38.3` -> `v0.39.0` | --- ### Release Notes <details> <summary>zarf-dev/zarf (zarf-dev/zarf)</summary> ### [`v0.39.0`](https://redirect.github.com/zarf-dev/zarf/releases/tag/v0.39.0) [Compare Source](https://redirect.github.com/zarf-dev/zarf/compare/v0.38.3...v0.39.0) ##### What's Changed - chore: update dos games release by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2921 - ci: id-token write application packages by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2923 - docs: update dos games example by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2924 - chore(deps): bump github/codeql-action from 3.26.4 to 3.26.5 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2927 - chore: schema adr by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2600 - fix: remove use of pkg/errors by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2937 - refactor: remove use of named returns in packager by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2940 - chore(deps): bump github/codeql-action from 3.26.5 to 3.26.6 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2948 - refactor: remove printing available Helm charts and versions when the Chart is not found by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2944 - refactor: remove connect strings from packager property by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2941 - fix(ci): test-imports workflow breaks when called from a fork by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2946 - feat: add health checks by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2678 - refactor: move finding table printing to CLI by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2960 - docs: update docs item in update Q2 roadmap by [@​eknowles](https://redirect.github.com/eknowles) in [zarf-dev/zarf#2958 - chore(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2957 - fix: progress bar image name flashes on push by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2965 ##### New Contributors - [@​eknowles](https://redirect.github.com/eknowles) made their first contribution in [zarf-dev/zarf#2958 **Full Changelog**: zarf-dev/zarf@v0.38.3...v0.39.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Description
This change moves printing of the findings table from linting to the CLI rather than in the pkg code.
Related Issue
Relates to #2576
Checklist before merging