New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add linter (2949) #3053

Merged

mkcp merged 61 commits into main from mkcp/2949-add-linter

Oct 3, 2024

Contributor

mkcp commented Oct 1, 2024 •

edited

Loading

Description

This PR completes the work in the other PRs that store and return errors from various empty and ignored returns. It should be merged after #2993 to ensure we don't add the lint rule before it's fulfilled and create a dirty CI state on main.

Related Issue

Fixes #2949
Depends on #2993
Relates to #2953

Checklist before merging

Test, docs, adr added or updated as needed
Contributor Guide Steps followed

mkcp added 30 commits

September 25, 2024 11:00


          add errcheck linting

358dd41

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          linter ignore some intentionally unhandled errs

655dd76

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          handle some env var set and unset errors in tests

cce62ce

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          make some notes in cmd/destroy.go for later

ae05ebb

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          direct handle some deferred cleanups to add direct error handling

992aa3c

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          capture errors from cmd/root

81e54f7

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          capture errors on src/config/config.go. checking ci

9b2b2e9

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: ensure we capture and propagate errors in src/internal

a508aa7

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: propagate or log unhandled errors in src/cmd

6f53a29

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: check for or intentionally ignore some dangling errors in tests

4283faf

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: use RemoveAll not remove so it doesnt error every time

cd5fdc7

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: disabling the err catch to see if it's something i changed

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: should fix the directory not empty panic

4a0d6ef

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: see if CI is flaking with the original tests. probably just need…

4da92b9

… to nolint ignore them

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: these tests should clean up properly and not error

29c5d08

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: actually cleaning up the test with RemovalAll seems to cause a p…

dfdf78a

…anic

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: reintroduce the ext_in_cluster test error catches

5a4241e

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: missed a spot

ac3db17

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: e2e 24 - can we assert that this error exists or do we have to i…

3b274f7

…gnore it

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: address some fixmes before merge

a9d6266

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: does this work now?

ccabf6c

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: handle and propagate errors in pkg/utils

8a56cd5

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: propagate any errors in ColorPrintYAML

5addccc

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: propagate any errors in src/pkg/message

7c04dff

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: propagate any errors in src/pkg/variables

acdb601

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: propagate any errors in src/pkg/layout

803b55e

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: srcfile is already closed and the error handled, no need to defe…

ffc2d20

…r before loop

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fix: ensure errors from deferred resource cleanup are passed back to …

35cf75e

…caller

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          chore: undo linter rule for CI so we can merge incremental changes

53a175b

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          chore: undo the other linter rule

391296f

Signed-off-by: Kit Patella <kit@defenseunicorns.com>

mkcp removed the ready-for-review label

mkcp added 3 commits

October 2, 2024 11:37


          Merge branch 'main' into mkcp/2949-add-linter

025bd87


          remove bigbang linter exception

75a4532

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          remove extra slog import

350df60

Signed-off-by: Kit Patella <kit@defenseunicorns.com>

codecov bot commented Oct 2, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/cmd/package.go	0.00%	9 Missing ⚠️
src/pkg/utils/cosign.go	0.00%	3 Missing ⚠️

Files with missing lines	Coverage Δ
src/pkg/utils/cosign.go	`0.00% <0.00%> (ø)`
src/cmd/package.go	`0.00% <0.00%> (ø)`

mkcp added 5 commits

October 2, 2024 11:54


          cleanup some more merge cruft

c2ff39b

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          remove comment and add linter ignore for CI

c4b1789

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          Is this defer cleanup timing out CI?

f94e75d

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          do not error if we fail to find a cluster here

e1269a4

Signed-off-by: Kit Patella <kit@defenseunicorns.com>


          fixed this in another branch, snuck thru

74e9c2f

Signed-off-by: Kit Patella <kit@defenseunicorns.com>

mkcp added the ready-for-review label

mkcp added this to the v0.40.0 milestone

schristoff previously approved these changes

View reviewed changes


          Merge branch 'main' into mkcp/2949-add-linter

f346300

mkcp dismissed schristoff’s stale review via

f346300

October 3, 2024 15:04

mkcp requested a review from schristoff

October 3, 2024 15:35

mkcp enabled auto-merge

October 3, 2024 15:48

AustinAbro321 previously approved these changes

View reviewed changes

mkcp added this pull request to the merge queue

AustinAbro321 removed this pull request from the merge queue due to a manual request

AustinAbro321 reviewed

View reviewed changes

src/test/external/ext_out_cluster_test.go Outdated Show resolved Hide resolved

mkcp dismissed AustinAbro321’s stale review via

29ffbbf

October 3, 2024 17:35


          Update src/test/external/ext_out_cluster_test.go

29ffbbf

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>

mkcp enabled auto-merge

October 3, 2024 18:05

AustinAbro321 approved these changes

View reviewed changes

mkcp added this pull request to the merge queue

Merged via the queue into main with commit e1a99f6

26 checks passed

mkcp deleted the mkcp/2949-add-linter branch

October 3, 2024 18:30

mjnagel pushed a commit to mjnagel/zarf that referenced this pull request


          feat: add linter (2949) (zarf-dev#3053)

e8b6c9f

Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review