fix: issue where kustomization files are empty #3094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a where
zarf
is unable to properly discover the images from a kustomization file.The culprit from my testing seems to be cause by
f
andnewDestination
being the same values when callinghelpers.CreatePathAndCopy
hereThat function, found here, basically copies a file from one path to another, however there is no check if the
source
anddestination
are same values. This causes the resulting file to be empty.The change in my PR uses the
temp
folder already created byzarf
to make sure that source and destination files are different, preventing an empty file from being scanned.Related Issue
Fixes #3065
Checklist before merging