Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move pkg oci to Zarf and log during health checks #3106

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

This moves the pkg kubernetes functions into Zarf to increase our flexibility in changes, and make the release lifecycle quicker.

Additionally this adds a logger to health checks, so when something goes wrong, it's clear to the user which resources were not ready

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 8f3411e
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/670fee250a30d10008ac9777

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 32.94118% with 57 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/healthchecks/healthchecks.go 49.09% 26 Missing and 2 partials ⚠️
src/pkg/cluster/cluster.go 0.00% 24 Missing ⚠️
src/internal/packager/helm/chart.go 0.00% 3 Missing ⚠️
src/internal/packager/helm/zarf.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/cluster/injector.go 71.48% <100.00%> (ø)
src/internal/packager/helm/zarf.go 0.00% <0.00%> (ø)
src/internal/packager/helm/chart.go 13.58% <0.00%> (+0.32%) ⬆️
src/pkg/cluster/cluster.go 0.00% <0.00%> (ø)
src/internal/healthchecks/healthchecks.go 58.33% <49.09%> (-30.56%) ⬇️

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review October 16, 2024 14:08
@AustinAbro321 AustinAbro321 requested review from a team as code owners October 16, 2024 14:08
@AustinAbro321 AustinAbro321 changed the title feat: move pkg oci to Zarf and add logger to health checks feat: move pkg oci to Zarf and log during health checks Oct 16, 2024
phillebaba
phillebaba previously approved these changes Oct 16, 2024
src/internal/healthchecks/healthchecks.go Outdated Show resolved Hide resolved
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 537ce04 Oct 17, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the move-pkg-oci-to-zarf branch October 17, 2024 16:08
mjnagel pushed a commit to mjnagel/zarf that referenced this pull request Oct 21, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants