-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move pkg oci to Zarf and log during health checks #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321
changed the title
feat: move pkg oci to Zarf and add logger to health checks
feat: move pkg oci to Zarf and log during health checks
Oct 16, 2024
phillebaba
reviewed
Oct 16, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
phillebaba
previously approved these changes
Oct 16, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
…move-pkg-oci-to-zarf
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
phillebaba
approved these changes
Oct 17, 2024
mjnagel
pushed a commit
to mjnagel/zarf
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the pkg kubernetes functions into Zarf to increase our flexibility in changes, and make the release lifecycle quicker.
Additionally this adds a logger to health checks, so when something goes wrong, it's clear to the user which resources were not ready
Checklist before merging