Remove import chaining from import package #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
phillebaba
force-pushed
the
import-chain
branch
from
c7f488e
to
44c1267
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
phillebaba
force-pushed
the
import-chain
branch
5 times, most recently
from
064211c
to
7872fd3
Compare
phillebaba
changed the title
phillebaba
force-pushed
the
import-chain
branch
from
7872fd3
to
1a421fa
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
import-chain
branch
from
1a421fa
to
9825995
Compare
schristoff
approved these changes
Oct 18, 2024
mjnagel
pushed a commit
to mjnagel/zarf
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Philip Laine <philip.laine@gmail.com> Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes use of import chaining from the init package. This is because we have removed support for this in the Skeleton packages and will do the same for "normal" packages. While this does add some code duplication it also makes the k3s package easier to understand.
Related Issue
Relates to #2969
Checklist before merging