Fix release by removing package delete #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Laine <philip.laine@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
phillebaba
force-pushed
the
fix/release-clean
branch
from
9e2e81d
to
3dae8d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
schristoff
approved these changes
Oct 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mjnagel
pushed a commit
to mjnagel/zarf
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Philip Laine <philip.laine@gmail.com> Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package delete logic removes more than it should. This change removes it from the clean action to fix the release process.
Related Issue
Checklist before merging