Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add logger to packager2 Mirror #3152

Merged
merged 3 commits into from
Oct 29, 2024
Merged

chore: add logger to packager2 Mirror #3152

merged 3 commits into from
Oct 29, 2024

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Oct 28, 2024 •
edited
Loading

Description

Does what it says on the tin

Related Issue

Relates to #2576

Checklist before merging

@mkcp
add logger to packager2 Mirror
abfb4e7 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp mkcp self-assigned this Oct 28, 2024
@mkcp mkcp requested review from a team as code owners October 28, 2024 18:20
@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 4b623a7
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/671fe8ac7a731300083bed5e

@mkcp
Copy link
Contributor Author

mkcp commented Oct 28, 2024

Accidentally pushed a commit intended for a fresh branch. Force-pushed to undo

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/cluster/tunnel.go 0.00% 17 Missing ⚠️
src/internal/packager2/mirror.go 0.00% 5 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/mirror.go 0.00% <0.00%> (ø)
src/pkg/cluster/tunnel.go 10.36% <0.00%> (-0.52%) ⬇️

... and 1 file with indirect coverage changes

@mkcp
add remove message.DebugWriter passthru and add some slogs to tunnel
5093b36 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
make linter happy with goimports
4b623a7 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp mkcp enabled auto-merge October 29, 2024 18:24
@mkcp mkcp added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 96c5afa Oct 29, 2024
26 checks passed
@mkcp mkcp deleted the mkcp/slog-package-mirror branch October 29, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

Assignees

@mkcp mkcp

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkcp @AustinAbro321