Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: begin adding logger to zarf dev #3163

Merged
merged 5 commits into from
Oct 31, 2024
Merged

chore: begin adding logger to zarf dev #3163

merged 5 commits into from
Oct 31, 2024

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Oct 29, 2024 •
edited
Loading

Description

This PR adds logger to sha256sum, patch-git, lint and find-images. There's a few more dev commands to update, which i'll grab in another PR.

Related Issue

Relates to #2576

Checklist before merging

@mkcp
ensure we print out a lint table even when logger is enabled
707335e 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
add logger to dev find-images
62e08b6 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp mkcp self-assigned this Oct 29, 2024
@mkcp mkcp requested review from a team as code owners October 29, 2024 22:09
@mkcp mkcp enabled auto-merge October 29, 2024 22:09
@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit d7b2f0d
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6722660e03bca4000747b336

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 31.57895% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/dev.go 0.00% 18 Missing ⚠️
src/pkg/packager/prepare.go 60.00% 8 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/prepare.go 53.46% <60.00%> (+2.43%) ⬆️
src/cmd/dev.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@mkcp
remove some fixmes and add logger to dev sha256sum
32d455b 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
AustinAbro321
AustinAbro321 reviewed Oct 30, 2024
View reviewed changes
src/cmd/dev.go Outdated Show resolved Hide resolved
@mkcp
pluralize log messages dealing with images
71eae1c 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp
fix transform log breaking on log fn pass-in
d7b2f0d 
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp mkcp added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 89a7fa0 Oct 31, 2024
26 checks passed
@mkcp mkcp deleted the mkcp/slog-cmddev branch October 31, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

Assignees

@mkcp mkcp

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkcp @AustinAbro321