-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually use emptydir mount when persistence is disabled #3241
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
In zarf-dev#2124, an emptydir was mounted when `persistence.enabled: false` is set. However, this is not enough to make registry work: it crashloops as in issue zarf-dev#1998. This is fixed by setting the env variable specifying storage config even if persistence is disabled. Signed-off-by: Adam Michalik <amichalik@anduril.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚨 Try these New Features:
|
Hey, really appreciate this PR, and this is a bug. The |
To provide some context, I use this to bootstrap Zarf on a cluster where there's no PV provisioner available. The way I do it is to install Rancher's
Without this, I'd need to make |
Description
In #2124, an emptydir was mounted when
persistence.enabled: false
is set. However, this is not enough to make registry work: it crashloops as in issue #1998:This is fixed by setting the env variable specifying storage config even if persistence is disabled:
Related Issue
Fixes #1998
Checklist before merging