Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Update SilenceErrors note #3356

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Suggestion: Update SilenceErrors note #3356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e239202
Suggestion: Update SilenceErrors note
RothAndrew Dec 20, 2024
24406d1
Merge branch 'main' into patch-1
RothAndrew Dec 20, 2024
0ff45cb
Merge branch 'main' into patch-1
RothAndrew Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,7 @@ func NewZarfCommand() *cobra.Command {
Long: lang.RootCmdLong,
Args: cobra.MaximumNArgs(1),
SilenceUsage: true,
// TODO(mkcp): Do we actually want to silence errors here?
SilenceErrors: true,
SilenceErrors: true, // If false, Cobra will emit unstructured log lines. We don't want that. We'd rather emit our own slog lines when returning an error.
PersistentPreRunE: preRun,
Run: run,
}
Expand Down
Loading