Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource requests and limits to Utility Cluster deployments #59

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Add resource requests and limits to Utility Cluster deployments #59

merged 1 commit into from
Sep 26, 2021

Conversation

RothAndrew
Copy link
Contributor

What/Why

  • Add resource requests and limits to Gitea and the private docker registry because not having them is a finding in kubescape and other k8s security tools

@RothAndrew
Add resource requests and limits to Utility Cluster deployments
347b9ea 
## What/Why

- Add resource requests and limits to Gitea and the private docker registry because not having them is a finding in `kubescape` and other k8s security tools
@RothAndrew RothAndrew self-assigned this Sep 24, 2021
@RothAndrew RothAndrew mentioned this pull request Sep 24, 2021
Closed
jeff-mccoy
jeff-mccoy reviewed Sep 24, 2021
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question--how did you determine the resource values? They seem reasonable, just curious

@RothAndrew
Copy link
Contributor Author

quick question--how did you determine the resource values? They seem reasonable, just curious

I watched their max usage using k9s, which was in both cases early on in startup and loading of the package, and made those the requests, then added limits as some multiple of the request that felt right.

jeff-mccoy
jeff-mccoy approved these changes Sep 26, 2021
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay seems reasonable, we probably need to do something to formalize how we define resources for edge use cases where this could really impact where the utility cluster can run

@jeff-mccoy jeff-mccoy merged commit c12f6d5 into master Sep 26, 2021
@jeff-mccoy jeff-mccoy deleted the feature/add_resources_to_utility_cluster branch September 26, 2021 21:10
@RothAndrew
Copy link
Contributor Author

Maybe we could do something like specify the minimal amount that it is reasonably expected to work (slowly) and offer the ability to customize it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

Assignees

@RothAndrew RothAndrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RothAndrew @jeff-mccoy