Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Terratest E2E test work to the CI pipeline #95

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

RothAndrew
Copy link
Contributor

@RothAndrew RothAndrew commented Oct 7, 2021

What/Why

Working PoC here: https://github.com/defenseunicorns/slash-command-dispatch-test/pull/5

  • Remove hello and quote from the CI pipeline. We have real stuff to put in there now.
  • Add e2e to CI pipeline. Run by adding /test e2e or /test all to a comment in any PR in this repo (after this gets merged)
    • Runs the new Terratest-based E2E test suite, which currently only consists of one test
  • New required repo secret: AWS_ACCESS_KEY_ID_DEFENSEUNICORNS_COMMERCIAL_SA_ZARF (I created a user sa-zarf in the commercial AWS account)
  • New required repo secret: AWS_SECRET_ACCESS_KEY_DEFENSEUNICORNS_COMMERCIAL_SA_ZARF
  • New required repo secret: REGISTRY1_USERNAME_ROTHANDREW2 (will quickly be replaced by a service account once I get access to the secrets from the Zarf repo in Repo1)
  • New required repo secret: REGISTRY1_PASSWORD_ROTHANDREW2 (will quickly be replaced by a service account once I get access to the secrets from the Zarf repo in Repo1)
  • Break out the build-cli Makefile target into clean, build-cli-linux, and build-cli-mac for better efficiency in the pipeline

@RothAndrew RothAndrew self-assigned this Oct 7, 2021
@RothAndrew RothAndrew marked this pull request as ready for review October 7, 2021 20:37
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable besides the asdf comment, just not sure what’s happening there and looking at it on mobile so lots of scrolling.

.github/workflows/test-command.yml Show resolved Hide resolved
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash on merge please, lgtm

@RothAndrew RothAndrew merged commit e5f5556 into master Oct 7, 2021
@RothAndrew RothAndrew deleted the feature/add-terratest-e2e-to-pipeline branch October 7, 2021 21:05
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants