Update static typing #213
Merged
Update static typing #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixed mypy pyproject.toml config 2. Move mypy from pre-commit to pyproject.toml 3. Lint in CI
for more information, see https://pre-commit.ci
TomAugspurger
commented
Aug 5, 2024
added 2 commits
August 6, 2024 08:05
TomAugspurger
had a problem deploying
to
test-release
GitHub Actions
Failure
TomAugspurger
had a problem deploying
to
test-release
GitHub Actions
Failure
TomAugspurger
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomAugspurger
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomAugspurger
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomAugspurger
temporarily deployed
to
test-release
GitHub Actions
Inactive
|
CI is passing now. |
TomNicholas
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates how we do static type checking, and fixes some issues on
main.The biggest change is moving the
mypylinting check out of.pre-commit. As mentioned in #209, we need all the typed dependencies in the environment running the check. The one managed by .pre-commit was lacking several dependencies (like xarray and Zarr) and so we weren't benefiting from static type checking at those boundaries. We can move it back into pre-commit, but we need to make sure that all our dependencies are duplicated there.I'll explain some of the type changes inline.