Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor kerchunk reader tests to call open_virtual_dataset #317

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Refactor kerchunk reader tests to call open_virtual_dataset #317

merged 2 commits into from
Nov 25, 2024

Conversation

TomNicholas
Copy link
Member

@norlandrhagen this refactors the tests in test_readers/test_kerchunk.py to all call open_virtual_dataset directly instead of calling the internal function dataset_from_kerchunk_refs. This will help me test that passing fs_root to open_virtual_dataset is working as expected.

  • Makes testing passing the fs_root argument in Paths as URIs #243 possible
  • Tests passing
  • Full type hint coverage

@TomNicholas TomNicholas added Kerchunk Relating to the kerchunk library / specification itself testing readers labels Nov 23, 2024
@TomNicholas TomNicholas mentioned this pull request Nov 23, 2024
Merged
25 tasks
@TomNicholas TomNicholas merged commit 3d7a4be into main Nov 25, 2024
11 checks passed
@TomNicholas TomNicholas deleted the refactor_kerchunk_reader_tests branch November 25, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Kerchunk Relating to the kerchunk library / specification itself readers testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TomNicholas