Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure flake8's line length as 100 #124

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Configure flake8's line length as 100 #124

merged 1 commit into from
Nov 16, 2018

Conversation

jakirkham
Copy link
Member

This allows users to run flake8 numcodecs and pick up the desired configuration by default.

[Description of PR]

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py37 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@jakirkham
Configure flake8's line length as 100
94ac6eb 
This allows users to run `flake8 numcodecs` and pick up the desired
configuration by default.
@jakirkham jakirkham requested a review from alimanfoo November 10, 2018 01:33
alimanfoo
alimanfoo approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't know this was possible!

@alimanfoo alimanfoo added this to the 0.6.0 milestone Nov 15, 2018
@jakirkham jakirkham merged commit 264aa2d into zarr-developers:master Nov 16, 2018
@jakirkham jakirkham deleted the config_flake8_line_len branch November 16, 2018 16:31
@jakirkham jakirkham mentioned this pull request Nov 16, 2018
Merged
7 tasks
@jakirkham
Copy link
Member Author

Added PR ( zarr-developers/zarr-python#335 ) to do the same for Zarr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo alimanfoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jakirkham @alimanfoo