Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to migrate to Gh-action. #265

Closed
wants to merge 1 commit into from
Closed

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Jan 6, 2021

As we are out of time on .travis-ci for the zarr org.

[Description of PR]

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py38 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@jakirkham
Copy link
Member

Thanks for starting this Matthias! 😄

It looks like GitHub Actions doesn't provide us a compiler atm. Not sure how we add one. Maybe a simple solution would be to use the same image we use for wheels here. That way we are building in the same environment we later use for deployment. Though open to other ideas if you have thoughts 🙂

@Carreau Carreau mentioned this pull request Jan 6, 2021
@Carreau
Copy link
Contributor Author

Carreau commented Jan 6, 2021

I've tried to fix osx; but was unable to without using conda. See #266 for part of a solution.
I'm not sure if building wheels on conda is fine or not and would lead to issues on non-conda installs.

As we are out of time on .travis-ci for the zarr org.
@jakirkham
Copy link
Member

Are there changes from here that we would like to integrate as well?

@joshmoore
Copy link
Member

There doesn't seem to be anything here that's not in https://github.com/zarr-developers/numcodecs/blob/main/.github/workflows/ci-linux.yaml

@joshmoore joshmoore closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants