Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix osx ci-build. #266

Merged
merged 1 commit into from
Jan 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions .github/workflows/ci-osx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.5", "3.6", "3.7", "3.8"]
python-version: ["3.6", "3.7", "3.8"]

steps:
- name: Checkout source
Expand All @@ -17,17 +17,28 @@ jobs:
submodules: recursive

- name: Set up Python
uses: actions/setup-python@v1
uses: conda-incubator/setup-miniconda@master
with:
python-version: ${{ matrix.python-version }}

channels: conda-forge
python-version: ${{ matrix.python-version }}
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
- name: Install numcodecs
shell: "bash -l {0}"
run: |
python -m pip install -U pip setuptools wheel pytest
python -m pip install -v -e .

- name: List installed packages
run: python -m pip list
conda create -n env python==${{matrix.python-version}} wheel cython numpy msgpack-python pytest wheel pip compilers
conda activate env
which pip
conda env export
- name: Install numcodecs
shell: "bash -l {0}"
run: |
conda activate env
export CC=clang
python setup.py build

- name: Run tests
run: pytest -v --pyargs numcodecs
shell: "bash -l {0}"
run: |
conda activate env
pytest -v --pyargs numcodecs
2 changes: 1 addition & 1 deletion .github/workflows/wheel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
env:
CIBW_TEST_COMMAND: pytest --pyargs numcodecs
CIBW_TEST_REQUIRES: pytest
CIBW_SKIP: "*27* pp*"
CIBW_SKIP: "*27* pp* *35*"
CIBW_ENVIRONMENT: "DISABLE_NUMCODECS_AVX2=1"
CIBW_ENVIRONMENT_MACOS: "MACOSX_DEPLOYMENT_TARGET=10.9 DISABLE_NUMCODECS_AVX2=1"

Expand Down
5 changes: 5 additions & 0 deletions docs/release.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Release notes
=============

* Remove support for Python 3.5 which is end of life. While the code base might
still be compatible; the source dist and wheel are marked as Python 3.6+ and
pip will not install them. Continuous integration on Python 3.5 has been
disabled.

.. _release_0.7.2:

0.7.2
Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,9 @@ def run_setup(with_extensions):
},
ext_modules=ext_modules,
cmdclass=cmdclass,
package_dir={'': '.'},
packages=['numcodecs', 'numcodecs.tests'],
package_dir={"": "."},
python_requires=">=3.6, <4",
packages=["numcodecs", "numcodecs.tests"],
classifiers=[
'Development Status :: 4 - Beta',
'Intended Audience :: Developers',
Expand All @@ -330,7 +331,6 @@ def run_setup(with_extensions):
'Topic :: Software Development :: Libraries :: Python Modules',
'Operating System :: Unix',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand Down