Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge comparisons with in #432

Merged
merged 2 commits into from
May 7, 2023
Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 6, 2023

To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained in it instead of checking for equality against each of the values.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #432 (0f787aa) into main (8d2bac0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #432   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         2121      2121           
=========================================
  Hits          2121      2121           
Impacted Files Coverage Δ
numcodecs/tests/test_zfpy.py 100.00% <100.00%> (ø)

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented May 6, 2023

The docs build CI error is unrelated. Requires a separate PR to fix.

The important part of the log is probably:

Running Sphinx v7.0.0

See #433. Should be fixed by #434.

@joshmoore
Copy link
Member

Thanks, @DimitriPapadopoulos. With the RTD fix, things are now green.

@joshmoore joshmoore merged commit 35b6631 into zarr-developers:main May 7, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the in branch May 7, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants