Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in CI jobs #467

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 29, 2023

  !!

          ********************************************************************************
          newlines are not allowed in `summary` and will break in the future
          ********************************************************************************

  !!

See for example https://github.com/zarr-developers/numcodecs/actions/runs/6348938987/job/17246365647.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@DimitriPapadopoulos DimitriPapadopoulos changed the title Fix warning in CI job Fix warning in CI jobs Sep 29, 2023
  !!

          ********************************************************************************
          newlines are not allowed in `summary` and will break in the future
          ********************************************************************************

  !!
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the newlines_are_not_allowed_in_summary branch from 4fba9ac to 055b6ae Compare September 29, 2023 09:13
@joshmoore
Copy link
Member

Ignoring the unrelated build failure. Thanks, @DimitriPapadopoulos

@joshmoore joshmoore merged commit 515d097 into zarr-developers:main Oct 4, 2023
19 of 23 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the newlines_are_not_allowed_in_summary branch October 4, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants