Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for floating point transforms in FixedScaleOffset #566

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Aug 26, 2024

Some tests for floating point parameters in FixedScaleOffset, to go with #356.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (6fb781b) to head (cb2a8ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2407     2408    +1     
=======================================
+ Hits         2405     2406    +1     
  Misses          2        2           
Files with missing lines Coverage Δ
numcodecs/tests/test_fixedscaleoffset.py 100.00% <100.00%> (ø)

@dstansby dstansby marked this pull request as ready for review August 26, 2024 08:24
@dstansby dstansby requested a review from jakirkham September 16, 2024 16:32
@dstansby dstansby merged commit d8a219f into zarr-developers:main Nov 7, 2024
26 checks passed
@dstansby dstansby deleted the fix-scale-tests branch November 7, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant