Apply and enforce more ruff rules #594

DimitriPapadopoulos · 2024-10-09T16:35:17Z

[Description of PR]

TODO:

Unit tests and/or doctests in docstrings
Tests pass locally
Docstrings and API docs for any new/modified user-facing classes and functions
Changes documented in docs/release.rst
Docs build locally
GitHub Actions CI passes
Test coverage to 100% (Codecov passes)

PT006 Wrong type passed to first argument of `@pytest.mark.parametrize`; expected `tuple`

PT007 Wrong values type in `@pytest.mark.parametrize` expected `list` of `tuple`

EXE001 Shebang is present but file is not executable

SIM102 Use a single `if` statement instead of nested `if` statements

SIM105 Use `contextlib.suppress(ImportError)` instead of `try`-`except`-`pass`

RSE102 Unnecessary parentheses on raised exception

codecov · 2024-10-09T16:38:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (8edd3f9) to head (e7f02b7).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2332     2332           
=======================================
  Hits         2330     2330           
  Misses          2        2

Files with missing lines	Coverage Δ
numcodecs/lzma.py	`100.00% <100.00%> (ø)`
numcodecs/registry.py	`100.00% <100.00%> (ø)`
numcodecs/tests/test_blosc.py	`100.00% <100.00%> (ø)`
numcodecs/tests/test_json.py	`100.00% <ø> (ø)`
numcodecs/tests/test_msgpacks.py	`100.00% <ø> (ø)`
numcodecs/tests/test_shuffle.py	`100.00% <100.00%> (ø)`

DimitriPapadopoulos added 11 commits October 9, 2024 18:13

Deprecate a couple ruff/pyupgrade rules (UP)

9e0e2d3

Enforce ruff/flake8-pytest-style rules (PT)

f41ef2f

Apply ruff/flake8-pytest-style rule PT006

62aa41e

PT006 Wrong type passed to first argument of `@pytest.mark.parametrize`; expected `tuple`

Apply ruff/flake8-pytest-style rule PT007

974cd4f

PT007 Wrong values type in `@pytest.mark.parametrize` expected `list` of `tuple`

Enforce ruff/flake8-bugbear rules (B)

c0afb35

Apply ruff/flake8-executable rule EXE001

246212c

EXE001 Shebang is present but file is not executable

Enforce ruff/pygrep-hooks rules (PGH)

d5c58c2

Apply ruff/flake8-simplify rule SIM102

82385fd

SIM102 Use a single `if` statement instead of nested `if` statements

Apply ruff/flake8-simplify rule SIM105

8f9efae

SIM105 Use `contextlib.suppress(ImportError)` instead of `try`-`except`-`pass`

Apply ruff/flake8-raise rule RSE102

47ce27e

RSE102 Unnecessary parentheses on raised exception

Enforce ruff/flake8-raise rules (RSE)

e7f02b7

dstansby approved these changes Oct 9, 2024

View reviewed changes

dstansby merged commit e836f39 into zarr-developers:main Oct 9, 2024
30 checks passed

DimitriPapadopoulos deleted the ruff branch October 9, 2024 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply and enforce more ruff rules #594

Apply and enforce more ruff rules #594

DimitriPapadopoulos commented Oct 9, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading

Apply and enforce more ruff rules #594

Apply and enforce more ruff rules #594

Conversation

DimitriPapadopoulos commented Oct 9, 2024 • edited Loading

codecov bot commented Oct 9, 2024 • edited Loading

Codecov Report

DimitriPapadopoulos commented Oct 9, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading