Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce ruff/flake8-comprehensions rules (C4) #605

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 15, 2024

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (29995e3) to head (bcb3ab2).

❗ There is a different number of reports uploaded between BASE (29995e3) and HEAD (bcb3ab2). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (29995e3) HEAD (bcb3ab2)
12 4
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   99.81%   90.08%   -9.74%     
==========================================
  Files          62       62              
  Lines        2712     2712              
==========================================
- Hits         2707     2443     -264     
- Misses          5      269     +264     
Files with missing lines Coverage Δ
numcodecs/abc.py 100.00% <100.00%> (ø)
numcodecs/categorize.py 100.00% <100.00%> (ø)
numcodecs/delta.py 100.00% <100.00%> (ø)
numcodecs/fixedscaleoffset.py 100.00% <100.00%> (ø)
numcodecs/json.py 96.07% <100.00%> (ø)
numcodecs/msgpacks.py 100.00% <100.00%> (ø)
numcodecs/pickles.py 100.00% <100.00%> (ø)
numcodecs/quantize.py 100.00% <100.00%> (ø)
numcodecs/tests/test_blosc.py 100.00% <100.00%> (ø)
numcodecs/tests/test_lzma.py 100.00% <ø> (ø)
... and 1 more

... and 2 files with indirect coverage changes

C401 Unnecessary generator (rewrite as a `set` comprehension)
C408 Unnecessary `dict` call (rewrite as a literal)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant