Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum numpy pin #628

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Fix minimum numpy pin #628

merged 3 commits into from
Nov 9, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Nov 9, 2024

Fixes a mistake in #622

Also fixes issues introduced by #524. The problem was zarr==3 has a numpy>=1.25 pin, which doesn't adhere to SPEC 0 and our pin (currently numpy>=1.24), so on Python 3.11 don't install and run the zarr v3 tests.

@dstansby dstansby requested a review from normanrz November 9, 2024 10:47
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (44130cd) to head (51fcbbe).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          62       62           
  Lines        2691     2691           
=======================================
  Hits         2689     2689           
  Misses          2        2           
Files with missing lines Coverage Δ
numcodecs/tests/test_zarr3.py 100.00% <100.00%> (ø)

@normanrz
Copy link
Contributor

normanrz commented Nov 9, 2024

Thanks!

@dstansby dstansby merged commit a7a698d into zarr-developers:main Nov 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants