Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PCodec soft dependency handling #647

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jakirkham
Copy link
Member

As with other soft dependencies in Numcodecs, the pattern is to attempt to import them and if their dependencies cannot be resolved skip them. Have applied this pattern to PCodec to be consistent with the other optional codec dependencies.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (86f5ce4) to head (4cc252e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   99.92%   99.85%   -0.08%     
==========================================
  Files          62       62              
  Lines        2721     2720       -1     
==========================================
- Hits         2719     2716       -3     
- Misses          2        4       +2     
Files with missing lines Coverage Δ
numcodecs/__init__.py 100.00% <100.00%> (ø)
numcodecs/pcodec.py 100.00% <100.00%> (ø)
numcodecs/tests/test_pcodec.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@jakirkham
Copy link
Member Author

@dstansby could you please review this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant