-
-
Notifications
You must be signed in to change notification settings - Fork 274
Apply Repo-Review suggestions to zarr-python? #1701
Replies: 2 comments · 2 replies
-
I would! if any of the changes would affect development, then we should get them into the v3 branch |
Beta Was this translation helpful? Give feedback.
All reactions
-
They would affect development in the sense that these new constraints might require to change the code in some places. However, the changes are usually quite simple, I believe they wouldn't imply complex merges down the road. Does this sound acceptable? Issues reported by "ruff check --select B"
Issues reported by "ruff check --select UP"
|
Beta Was this translation helpful? Give feedback.
All reactions
-
by "affect development" I was thinking of pretty big changes like using a |
Beta Was this translation helpful? Give feedback.
All reactions
-
I have started implementing the required changes in #1702, #1703, #1704, #1705, #1707, #1708. Once most of the issues are fixed, I plan on adding a GitHub Action to automatically run repo-review on the repository, typically using sp-repo-review. |
Beta Was this translation helpful? Give feedback.
-
Would you agree to an effort to apply Repo-Review suggestions from the Scientific Python Development Guide? Many of them make sense to me.
https://learn.scientific-python.org/development/guides/repo-review/?repo=zarr-developers%2Fzarr-python&branch=main
Beta Was this translation helpful? Give feedback.
All reactions