Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ruff/pyupgrade rules (UP) and fix issues #1703

Closed

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Mar 11, 2024

Keep applying repo-review suggestions (#1701).

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (cb4230d) to head (289ff29).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1703       +/-   ##
=========================================
+ Coverage      0   99.98%   +99.98%     
=========================================
  Files         0       38       +38     
  Lines         0    14674    +14674     
=========================================
+ Hits          0    14672    +14672     
- Misses        0        2        +2     
Files with missing lines Coverage Δ
zarr/_storage/store.py 100.00% <100.00%> (ø)
zarr/_storage/v3.py 100.00% <100.00%> (ø)
zarr/_storage/v3_storage_transformers.py 100.00% <100.00%> (ø)
zarr/creation.py 100.00% <100.00%> (ø)
zarr/hierarchy.py 99.79% <100.00%> (ø)
zarr/meta.py 100.00% <100.00%> (ø)
zarr/n5.py 100.00% <100.00%> (ø)
zarr/storage.py 100.00% <100.00%> (ø)
zarr/tests/test_core.py 99.94% <100.00%> (ø)
zarr/tests/test_n5.py 100.00% <ø> (ø)
... and 2 more

... and 26 files with indirect coverage changes

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review March 11, 2024 21:57
zarr/_storage/store.py Outdated Show resolved Hide resolved
As suggested by Repo-Review.
UP006 Use `dict` instead of `Dict` for type annotation
UP006 Use `list` instead of `List` for type annotation
UP006 Use `tuple` instead of `Tuple` for type annotation

https://docs.astral.sh/ruff/rules/non-pep585-annotation/
UP033 Use `@functools.cache` instead of `@functools.lru_cache(maxsize=None)`

https://docs.astral.sh/ruff/rules/lru-cache-with-maxsize-none/
UP035 Import from `collections.abc` instead: `Iterable`, `Iterator`, `Mapping`, `Sequence`

https://docs.astral.sh/ruff/rules/deprecated-import/
@jhamman
Copy link
Member

jhamman commented Jun 1, 2024

@DimitriPapadopoulos - thanks for moving your focus over to the v3 branch. I'm going to close this in favor of the contributions you've already made there. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants