-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/store metadata methods #1851
base: main
Are you sure you want to change the base?
Feature/store metadata methods #1851
Conversation
- adds Store.set_metadata and Store.get_metadata methods - moves json serialization/deserialization to Store ABC
blosc_configuration_json = zarr_json["codecs"][1]["configuration"] | ||
assert blosc_configuration_json["typesize"] == 1 | ||
assert blosc_configuration_json["shuffle"] == "bitshuffle" | ||
assert blosc_configuration_json["shuffle"] == BloscShuffle.bitshuffle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I threw this in because it makes the test pass but its really not what we want. We were previously letting json.dumps
do a lot of work to serialize Python objects. I think this means that we now need to push more of that logic into the to_dict()
methods on the Metadata objects.
cc @d-v-b
This PR takes adds the option for stores to store metadata in whatever container makes sense for the store.
Store.set_metadata
andStore.get_metadata
methodsMemoryStore
that now keeps metadata objects as plain dictionaries.toward #1755
TODO: