fix: selection with zarr arrays #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
commented
Aug 28, 2024
src/zarr/core/indexing.py
Outdated
Comment on lines
37
to
39
| Selector = ( | ||
| BasicSelector | ArrayOfIntOrBool | Array | ||
| ) # help! we want zarr.Array[np.intp] | zarr.Array[np.bool_] |
There was a problem hiding this comment.
I don't see a technical reason why it isn't possible to make Array a generic type over data types.
There was a problem hiding this comment.
happy to do this, can you point me in the right direction?
There was a problem hiding this comment.
@dstansby - I feel that you are going to be best positioned to do flesh out the generic Array type. Do you have time to take that on?
There was a problem hiding this comment.
Probably not (at least in the next month) :(
…nto fix/indexing-with-zarr-arrays
…nto fix/indexing-with-zarr-arrays
d-v-b
reviewed
Sep 24, 2024
normanrz
approved these changes
Sep 24, 2024
Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com>
jhamman
commented
Sep 24, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial solution to #2133. It works but does so in a potential suboptimal way -- materializing the entire indexer before indexing. A deeper solution would include streaming indexer chunks from the selector to oindex/vindex but I think that can wait until later.
closes #2133
TODO: