Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/empty listdir #2225

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fix/empty listdir #2225

merged 2 commits into from
Sep 24, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Sep 24, 2024

Fixes #2218
TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman merged commit a4b2509 into zarr-developers:v3 Sep 24, 2024
26 checks passed
@dcherian
Copy link
Contributor

dcherian commented Sep 24, 2024 •
edited
Loading

This doesn't seem to handle nested subdirectories.

a store with 0/0 as a key will report as empty.
Caught by #2202 hehe

@jhamman jhamman deleted the fix/empty-listdir branch September 24, 2024 15:44
dcherian added a commit to dcherian/zarr-python that referenced this pull request Sep 27, 2024
@dcherian
Merge branch 'v3' into generalize-stateful-store
80a83a1 
* v3:
  remove outdated v2 source code and tests from v3 branch (zarr-developers#2182)
  Fix/empty listdir (zarr-developers#2225)
  Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#2219)
  Added Attributes.asdict (zarr-developers#2221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocalStore.empty() is True if there are empty directories
3 participants
@jhamman @dcherian @d-v-b