Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default compressors to config #2470

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

brokkoli71
Copy link
Member

This PR adds:

  • default compressor for zarr_format=2
  • specification of default compressors dependent on dtype in zarr.config

fixes #2267

Should _get_default_array_bytes_codec for zarr_format=3 also be configurable in zarr.config?

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@brokkoli71
Copy link
Member Author

brokkoli71 commented Nov 6, 2024

I am a little confused: in which cases should we use VLenBytes and in which cases VLenUTF8? Or do we need both at the same time?

@brokkoli71
Copy link
Member Author

Also, do we need a default compressor or are default filters sufficient?

@brokkoli71 brokkoli71 marked this pull request as ready for review November 13, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] default compressor / codec pipeline
1 participant