-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework requirements for pyup.io #326
Rework requirements for pyup.io #326
Conversation
Tests are currently failing on PY37 because numcodecs is not building C extensions, I believe this is because I removed cython from the test environments and so an attempt is being made to build from generate C sources, but in current numcodecs release those are not compatible with PY37. This has been resolved upstream in numcodecs (zarr-developers/numcodecs#92) but that has not been released yet. A workaround is to ensure cython is ensured in the zarr CI environments, so numcodecs gets cythonized during install. |
OK, CI is green. @zarr-developers/core-devs any objections? |
LGTM, nice to see the simplified dev environment. |
Hm, can't figure out why coveralls has dropped since last commit. Looks like PY2 branches are not getting covered, but the PY2 CI run on travis completed fine. |
Maybe coveralls bug? Only affects storage.py, lines are marked as "uncov" yet have "1x" coverage. |
Rerunning Travis PY27 to see if coveralls gets fixed. |
Ah, sorry, there is one line uncovered, looks like it snuck in from #268. Will merge this and deal with that separately. |
This PR reworks the requirements to allow for automated management via the PyUP bot. Changes include:
requirements_dev*
files.requirements_test.txt
and are unpinned to avoid too much noise from PyUP.pip freeze
has been added to CI scripts to ensure we can debug exactly what packages were installed into the environment for any given CI run.TODO:
tox -e docs
)