Skip to content

don't serialize consolidated metadata if it's None #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d-v-b merged 2 commits into from
Oct 21, 2025
Merged

don't serialize consolidated metadata if it's None #3535

d-v-b merged 2 commits into from
Oct 21, 2025
+62 −2

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Oct 21, 2025

fixes #3521

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Oct 21, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Oct 21, 2025
@d-v-b d-v-b requested a review from maxrjones October 21, 2025 18:20
@d-v-b d-v-b changed the title don't serialize consolidated metadata if it's unset don't serialize consolidated metadata if it's None Oct 21, 2025
@d-v-b d-v-b mentioned this pull request Oct 21, 2025
Closed
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.86%. Comparing base (950066b) to head (5d41d1b).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3535   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          85       85           
  Lines       10111    10112    +1     
=======================================
+ Hits         6255     6256    +1     
  Misses       3856     3856
Files with missing lines Coverage Δ
src/zarr/core/group.py 70.27% <100.00%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b merged commit bc86a61 into zarr-developers:main Oct 21, 2025
31 checks passed
@d-v-b d-v-b deleted the fix/no-serialize-null-consolidated-metadata branch October 21, 2025 18:39
@kylebarron kylebarron mentioned this pull request Oct 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjones maxrjones maxrjones approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

consolidated_metadata: null

2 participants

@d-v-b @maxrjones