Skip to content

Conversation

@ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Nov 24, 2025

Fixes #3602

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Nov 24, 2025
@ilan-gold ilan-gold marked this pull request as draft November 24, 2025 23:52
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.14%. Comparing base (20670e6) to head (2286a2d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/zarr/core/chunk_grids.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3603      +/-   ##
==========================================
- Coverage   59.15%   59.14%   -0.02%     
==========================================
  Files          86       86              
  Lines       10170    10172       +2     
==========================================
  Hits         6016     6016              
- Misses       4154     4156       +2     
Files with missing lines Coverage Δ
src/zarr/core/chunk_grids.py 62.29% <66.66%> (-1.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilan-gold ilan-gold changed the title fix: match auto-chunking behavior across auto-sharding and not-auto-sharding fix: auto-chunking when auto-sharding 1MiB number Nov 25, 2025
@ilan-gold ilan-gold marked this pull request as ready for review November 25, 2025 17:41
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Nov 25, 2025
Comment on lines 65 to 66
if min_bytes >= max_bytes:
raise ValueError(f"Cannot have more min_bytes {min_bytes} than max_bytes {max_bytes}")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this would have caught the issue, so I figured I'd add it in

@d-v-b d-v-b enabled auto-merge (squash) November 27, 2025 16:06
@d-v-b d-v-b merged commit ee0e69a into zarr-developers:main Nov 27, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why do we aim for 1MiB (uncompressed) chunks when auto-sharding?

2 participants